NLog Target support ConnectionString with isolated TelemetryClient#2897
NLog Target support ConnectionString with isolated TelemetryClient#2897snakefoot wants to merge 7 commits intomicrosoft:mainfrom
Conversation
3e910a9 to
df34463
Compare
|
@cijothomas + @rajkumar-rangaraj + @TimothyMothra Fork of #2858 where I have changed to use isolated I don't mind also fixing log4net-appender if you like. Thus moving away from using Please review and merge. |
|
With all due respect, we are eagerly awaiting this change as the deadline for discontinuing instrumentation keys is approaching. |
Adding new methods to Public Api
|
@TimothyMothra Polite poke for review. Notice I don't mind updating log4net-appender as well (in new pull-request to resolve #2926) |
|
Hi @TimothyMothra can we have a review on this please? |
|
@TimothyMothra politely asking for a review. I have been looking to use OpenTelemetry.Instrumentation.AspNet instead but unfortunately this package is still in Beta. Would really be appreciated if the connectionstring fix will be included in the NLog package, at least untill OpenTelemetry for ASP.Net has been fully released. |
|
Now that instrumentation keys have been deprecated, I wanted to move to connection strings, but found out that NLog target does not support connection strings, only instrumentation keys. |
|
Still nothing? Is there nobody else to review this PR? |
|
The general direction for this repository is that we are not adding any new fixes/features unless there is special reason like security etc. The future direction is the OpenTelemetry SDK and we will work on closing the gaps. |
|
@xiang17 + @cijothomas + @rajkumar-rangaraj + @TimothyMothra Yes it could be awesome if the OpenTelemetry-Logging-API became public, so one could build bridges from NLog / Log4net / Serilog into the OpenTelemetry-Exporter-API. But sadly enough it has not been prioritized. Please prioritze merging this pull-request, since the ConnectionString is an existing feature. Believe this is more a bugfix, as the legacy InstrumentationKey is a dead end (Microsoft have burned the bridge before new is ready) |
|
I guess when #3001 is merged from develop-branch to main-branch and released, then this can be closed. |
Resolves #2714 - Add support for connection string to Microsoft.ApplicationInsights.NLogTarget
Changes
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors: